-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: standardize --admin-access-token usage #595
admin: standardize --admin-access-token usage #595
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 59.12% 59.27% +0.14%
==========================================
Files 32 32
Lines 3227 3224 -3
==========================================
+ Hits 1908 1911 +3
+ Misses 1319 1313 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
Could you please also update the Helm Chart to provide the access token to the cronjobs, and the docs to update the command usage examples?
This PR also needs to be rebased.
c943a01
to
6501019
Compare
Remove admin access token validation from some users-related utilities, as these checks are already performed by the admin CLI.
6501019
to
fd0af51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works as expected!
closes #489